Skip to content

Conversation

@TheFrogPad
Copy link
Member

Add WDT model support to specify WebLogic global roles and add documentation around existing Security section that specifies users and groups. Additional details on WLSRoles section can also be found in the JIRA task WDT-353.

@TheFrogPad
Copy link
Member Author

Hmmm... I have no clue why the last merge on the branch would fail wercker build as this was to update a simple typo in the markdown file plus I have no permission on the wercker project to see what may be wrong?

@TheFrogPad TheFrogPad changed the title Wdt 353 domain info wlsroles WDT-353: Add WLSRoles secition to domainInfo Jul 19, 2019
@TheFrogPad TheFrogPad changed the title WDT-353: Add WLSRoles secition to domainInfo WDT-353: Add WLSRoles section to domainInfo Jul 19, 2019
Copy link
Member

@ddsharpe ddsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and LGTM. Regarding the Wercker failure, it was an environmental issue. I reran the build on Wercker without any changes and it worked fine.

rakillen
rakillen previously approved these changes Jul 19, 2019
Copy link
Contributor

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor corrections

Copy link
Contributor

@CarolynRountree CarolynRountree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, after you address Rosemary's changes

@TheFrogPad TheFrogPad dismissed stale reviews from CarolynRountree and rakillen via 9ca8c8f July 22, 2019 22:26
@TheFrogPad TheFrogPad requested a review from ddsharpe July 22, 2019 22:31
rosemarymarano
rosemarymarano previously approved these changes Jul 23, 2019
rakillen
rakillen previously approved these changes Jul 23, 2019
@TheFrogPad TheFrogPad dismissed stale reviews from rakillen and rosemarymarano via bb284fd July 23, 2019 22:14
@ddsharpe ddsharpe merged commit 6a2ed17 into master Jul 24, 2019
@ddsharpe ddsharpe deleted the WDT-353-domain-info-wlsroles branch July 24, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants